feat(notify): optimize content of message #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
willzgli
commented
Nov 30, 2022
willzgli
commented
- change alert time to local time
- avoid using htlm escape charactors in message
leoryu
reviewed
Dec 1, 2022
pkg/notify/apiserver/handler.go
Outdated
| summary = fmt.Sprintf("%s %s", summary, evaluateValue) | ||
| } | ||
| unitValue := annotations[unitKey] | ||
| evaluateTypeValue := annotations[evaluateTypeKey] |
There was a problem hiding this comment.
please refer L203 of this file
There was a problem hiding this comment.
I means that who gaves this anno? This anno may be empty, maybe not be set.
leoryu
approved these changes
Dec 1, 2022
1. change alert time to local time 2. avoid using htlm escape charactors in message
huxiaoliang
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.