feat(platform): support skip validate item #2179
Conversation
| if isNeedValidateForDynamicItem(AnywhereValidateItemSelinux, cls) { | ||
| selinuxErrs = ValidateSelinux(fldPath, masters) | ||
| selinuxResult.Checked = true | ||
| log.Infof("cls %s's %s is validated", cls.Spec.DisplayName, AnywhereValidateItemSelinux) |
There was a problem hiding this comment.
这个日志再加一个 cls 的 name 吧，后台查的时候displayname好像不展示
There was a problem hiding this comment.
before cls created, cls doesn't have name.
| @@ -30,6 +30,8 @@ const ( | |||
| AnywhereValidateItemFirewall = "Firewall" | |||
| AnywhereValidateItemSelinux = "Selinux" | |||
| AnywhereValidateItemStorage = "Storage" | |||
| // validate all items | |||
| AnywhereValidateItemAll = "All" | |||
There was a problem hiding this comment.
再加点前缀吧，其余的check项名字还比较有辨识度，这个all容易和别的anno冲突
There was a problem hiding this comment.
this is anno value, not key.
| if validateMachine { | ||
| allErrs = append(allErrs, ValidateClusterMachines(cls, fldPath.Child("machines"))...) | ||
| if isNeedValidateForDynamicItem(AnywhereValidateItemStorage, cls) { |
There was a problem hiding this comment.
这个方法要不也挪validateClusterMachines里面？
There was a problem hiding this comment.
storage info is not in spec.machines, so we not set storage validate in machine. And storage validate just run once to check storage service, even the number of masters is 3, this is different with all items in machine validate.
There was a problem hiding this comment.
主要是你把这个放到 validateMachine==true 判断逻辑里，又搞了处理逻辑差异化～
There was a problem hiding this comment.
since if we dosen't have machines, we dosen't have any machine to ssh to validate storage service. So I set storage validate after machine validate.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: