feat(platform): machine provider support OnHealthCheck interface #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malc0lm
force-pushed
the
dev/provider-hc
branch
from
9b2e9ec to
9cb07f6
Compare
malc0lm
changed the title
|
LGTM |
Signed-off-by: malc0lm <[email protected]>
malc0lm
force-pushed
the
dev/provider-hc
branch
from
9cb07f6 to
70c4a94
Compare
malc0lm
changed the title
malc0lm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: malc0lm [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
The health checking use machine IP which acquired in tenant cluster node IP in machine controller. But in some scenario like SuperEdge, we use the node name to get the node. So machine health checking always failed.
In fact, health checking in provider need support user level implementation, this pr add
OnHealthCheckin machine provider, and mv the origin default implementation in DelegateProvider.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: