fix(application): exposed UpdateStatusFunc add Pre\PostUninstall repo #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoryu
reviewed
Oct 25, 2021
| @@ -38,45 +38,47 @@ type Hooks interface { | |||
| platformClient platformversionedclient.PlatformV1Interface, | |||
| app *applicationv1.App, | |||
| repo appconfig.RepoConfiguration, | |||
| updateStatusFunc updateStatusFunc) error | |||
| UpdateStatusFunc UpdateStatusFunc) error | |||
There was a problem hiding this comment.
the type‘s header can be upper, but why variable's header is upper?
GaoXiaodong
force-pushed
the
hotfix/application-hook
branch
from
879a9bc to
7907ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: