Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong peerDependencies for rxjs for Angular v14+ #126

Closed
BeratS opened this issue Oct 13, 2022 · 3 comments
Closed

[Bug] Wrong peerDependencies for rxjs for Angular v14+ #126

BeratS opened this issue Oct 13, 2022 · 3 comments

Comments

@BeratS
Copy link

BeratS commented Oct 13, 2022

Ngx-CookieConsent Version

4.0.0

CookieConsent Version

3.1.1

Angular CLI (or Nx CLI) Version

14

Node Version

16

OS Version

Windows

Expected Behaviour

peer rxjs@"~6.6.0" from [email protected]

The angular 14 it uses "rxjs": "~7.5.0",

I am not able to install other libraries - so I must use --force

Actual Behaviour

peer rxjs@"~6.6.0" from [email protected]

The angular 14 it uses "rxjs": "~7.5.0",

I am not able to install other libraries - so I must use --force

Steps to reproduce the behaviour

peer rxjs@"~6.6.0" from [email protected]

The angular 14 it uses "rxjs": "~7.5.0",

I am not able to install other libraries - so I must use --force

@tinesoft tinesoft changed the title [Bug] [Bug] Wrong peerDependencies for rxjs for Angular v14+ Oct 14, 2022
@tinesoft tinesoft self-assigned this Oct 14, 2022
@tinesoft
Copy link
Owner

@BeratS
Copy link
Author

BeratS commented Oct 16, 2022

Thanks a lot @tinesoft

@miguel-fulfil
Copy link

Fixed in https://github.com/tinesoft/ngx-cookieconsent/releases/tag/v4.0.1

@tinesoft this still causes a dependency conflict. We're on 14.2.7 with ionic and have been using rxjs 6.6.7 successfully. Migrating to rxjs 7 is not a requirement of @angular/core nor @angular/common - have to use [email protected]
https://github.com/angular/angular/blob/main/packages/core/package.json#L19
https://github.com/angular/angular/blob/main/packages/common/package.json#L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants