Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make protoc installation script respect proxy env #508

Merged

Conversation

mikonse
Copy link
Contributor

@mikonse mikonse commented Apr 4, 2023

see #507

Comment on lines 22 to 24
"peerDependencies": {
"proxy-agent": "^5.0.0"
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package looks decent. But should this be a peer dependency?
I'd expect a peer dependency for a host library (see the npm docs).

Happy to learn if there is a good reason, otherwise, best to go with a direct dependency here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I was thinking of this package being installed in a broader host context but since this is a hard requirement of this installation script making it a peer dependency does not make much sense.

@mikonse mikonse force-pushed the proxy-aware-protoc-installation branch from e774895 to 8c956b5 Compare April 4, 2023 19:02
@timostamm timostamm merged commit b262539 into timostamm:master Apr 5, 2023
timostamm added a commit that referenced this pull request Apr 5, 2023
@timostamm
Copy link
Owner

Hm I had to revert this in 3a5b9f9, unfortunately.

CI failed with:

lerna ERR! npm ci exited 1 in '@protobuf-ts/protoc'
lerna ERR! npm ci stderr:
npm ERR! Cannot read property 'proxy-agent' of undefined

And a local install failed with:

lerna info Bootstrapping 22 packages
lerna info Installing external dependencies
lerna ERR! npm install exited 1 in '@protobuf-ts/protoc'
lerna ERR! npm install stderr:
npm ERR! code ENOTFOUND
npm ERR! syscall getaddrinfo
npm ERR! errno ENOTFOUND
npm ERR! network request to https://npm.rsint.net/api/npm/rs_npm_virtual/xregexp/-/xregexp-2.0.0.tgz failed, reason: getaddrinfo ENOTFOUND npm.rsint.net

@mikonse
Copy link
Contributor Author

mikonse commented Apr 5, 2023

It seems I've made a small error with where I've regenerated the package-lock.json as I've had a local npm mirror configured.

If you just delete the package-lock.json and rerun npm install ist should generate a valid package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants