Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export createDefinition from @protobuf-ts/grpc-backend #307

Merged
merged 1 commit into from
May 16, 2022
Merged

export createDefinition from @protobuf-ts/grpc-backend #307

merged 1 commit into from
May 16, 2022

Conversation

eyalpost
Copy link
Contributor

We have a use case where we need to call createDefinition directly and not via adaptService. Would be great if this was exported

timostamm
timostamm approved these changes May 16, 2022
View reviewed changes
Copy link
Owner

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. The function makes sense on its own.

@timostamm timostamm changed the title export createDefinition export createDefinition from @protobuf-ts/grpc-backend May 16, 2022
@timostamm timostamm merged commit 2273a0e into timostamm:master May 16, 2022
@timostamm
Copy link
Owner

Released in v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyalpost @timostamm