Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.2 not working with 'exactOptionalPropertyTypes: true' #614

Closed
steida opened this issue Dec 6, 2023 · 1 comment · Fixed by #615
Closed

2.9.2 not working with 'exactOptionalPropertyTypes: true' #614

steida opened this issue Dec 6, 2023 · 1 comment · Fixed by #615

Comments

@steida
Copy link

steida commented Dec 6, 2023

"Type 'EncryptedMessage$Type' is not assignable to type 'IMessageType' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.\n Types of property 'messagePrototype' are incompatible.\n Type 'Readonly<{}> | undefined' is not assignable to type 'Readonly<{}>'.\n Type 'undefined' is not assignable to type 'Readonly<{}>'.",

2.9.1 is OK

@jcready
Copy link
Contributor

jcready commented Dec 7, 2023

This was my fault as there was a different property type definition between the IMessageType interface and the MessageType class which implements it for the newly added messagePrototype field. I apologize for the breakage and I've opened a PR which should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants