[BUG] The generate_dependencies parameter doesn't work

[jcready]

When debugging the issue I was able to narrow it down to this method:

protobuf-ts/packages/plugin-framework/src/descriptor-info.ts

Lines 633 to 653 in 54d5e99

	isTypeUsed(type: AnyTypeDescriptorProto, inFiles: FileDescriptorProto[]): boolean {
	let used = false;
	for (let fd of inFiles) {
	this.tree.visitTypes(fd, typeDescriptor => {
	if (used) return;
	if (DescriptorProto.is(typeDescriptor)) {
	const usedInField = typeDescriptor.field.includes(type);
	if (usedInField) {
	used = true;
	}
	} else if (ServiceDescriptorProto.is(typeDescriptor)) {
	const usedInMethodInput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.inputType!) === type);
	const usedInMethodOutput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.outputType!) === type);
	if (usedInMethodInput || usedInMethodOutput) {
	return true;
	}
	}
	})
	}
	return used;
	}

I was able to resolve the issue by changing the method to do the following:

 isTypeUsed(type: AnyTypeDescriptorProto, inFiles: FileDescriptorProto[]): boolean {
     // Probably not the right way to get this
     const normalizedTypeName = this.nameLookup._reverse.get(type);
     let used = false;
     for (let fd of inFiles) {
         if (used) return used;
         this.tree.visitTypes(fd, typeDescriptor => { 
             if (used) return;
             if (DescriptorProto.is(typeDescriptor)) {
                 const usedInField = typeDescriptor.field
                     .map(f => f.typeName)
                     .filter(Boolean)
                     .map(this.nameLookup.normalizeTypeName)
                     .includes(normalizedTypeName);
                 if (usedInField) {
                     used = true;
                 }
             } else if (ServiceDescriptorProto.is(typeDescriptor)) { 
                 const usedInMethodInput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.inputType!) === type); 
                 const usedInMethodOutput = typeDescriptor.method.some(md => this.nameLookup.resolveTypeName(md.outputType!) === type); 
                 if (usedInMethodInput || usedInMethodOutput) { 
                     used = true; 
                 } 
             } 
         }) 
     } 
     return used; 
 } 

I'd be happy to open a PR if you think this is the correct way to resolve the issue.

[timostamm]

Good catch, @jcready. PR is welcome!

A test case would be nice (but not required), see descriptor-registry.spec.ts for example.

    // Probably not the right way to get this
    const normalizedTypeName = this.nameLookup._reverse.get(type);

You should be able to use makeTypeName:

    const normalizedTypeName = this.nameLookup.makeTypeName(type);

[timostamm]

Hey @jcready, I just added your fix. Hope you don't mind, and thank you.

[jcready]

No worries! I've been a bit busy with other things to make time for a proper PR with test coverage. Thank you for fixing the issue and the excellent library!

[timostamm]

Released in v2.0.0-alpha.12