Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslint is deprecated #291

Closed
Zamiell opened this issue Apr 22, 2022 · 2 comments
Closed

tslint is deprecated #291

Zamiell opened this issue Apr 22, 2022 · 2 comments

Comments

@Zamiell
Copy link

Zamiell commented Apr 22, 2022

Greetings, and thanks for the excellent library.

I'm using @protobuf-ts/plugin for the first time and I'm noticing that it creates the following comment at the top of the file:

image

Some things:

1) Comment Stacking

Is it a bug that there are commas instead of newlines between the comments? Naively, I would expect it to look like:

// comment 1
// comment 2
// comment 3

Instead of:

// comment 1,// comment 2,// comment 3

2) TSLint is Deprecated

TSLint has been deprecated for over 3 years, so the // tslint:disable should be replaced with /* eslint-disable */.

@Zamiell
Copy link
Author

Zamiell commented Apr 23, 2022

Oh, I'm noticing now that the "comment stacking" problem seems to be fixed by #289.

@timostamm
Copy link
Owner

Oh yes, that was a regression, sorry about that.

Agree on TSLint - this is going to be replaced by eslint in the next major release. In the meantime, you can set the plugin option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants