We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greetings, and thanks for the excellent library.
I'm using @protobuf-ts/plugin for the first time and I'm noticing that it creates the following comment at the top of the file:
Some things:
Is it a bug that there are commas instead of newlines between the comments? Naively, I would expect it to look like:
// comment 1 // comment 2 // comment 3
Instead of:
// comment 1,// comment 2,// comment 3
TSLint has been deprecated for over 3 years, so the // tslint:disable should be replaced with /* eslint-disable */.
// tslint:disable
/* eslint-disable */
The text was updated successfully, but these errors were encountered:
Oh, I'm noticing now that the "comment stacking" problem seems to be fixed by #289.
Sorry, something went wrong.
Oh yes, that was a regression, sorry about that.
Agree on TSLint - this is going to be replaced by eslint in the next major release. In the meantime, you can set the plugin option.
No branches or pull requests
Greetings, and thanks for the excellent library.
I'm using @protobuf-ts/plugin for the first time and I'm noticing that it creates the following comment at the top of the file:
Some things:
1) Comment Stacking
Is it a bug that there are commas instead of newlines between the comments? Naively, I would expect it to look like:
Instead of:
// comment 1,// comment 2,// comment 3
2) TSLint is Deprecated
TSLint has been deprecated for over 3 years, so the
// tslint:disable
should be replaced with/* eslint-disable */
.The text was updated successfully, but these errors were encountered: