problem with how file names are resolved

[kleinschmidt]

I'm getting errors on nightly whenever I have Revise loaded and try to load something innocuous like StatsBase. As far as I can tell it's because Revise is trying to load files from the current working directory:

   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.2158 (2017-10-16 06:42 UTC)
 _/ |\__'_|_|_|\__'_|  |  master/eae7104bf (fork: 74 commits, 16 days)
|__/                   |  x86_64-pc-linux-gnu

julia> using Revise

julia> using StatsBase

ERROR (unhandled task failure): could not open file /home/dave/Downloads/julia-eae7104bf9/arraymacros.jl
Stacktrace:
 [1] include_relative(::Module, ::String) at ./loading.jl:533
 [2] include at ./sysimg.jl:14 [inlined]
 [3] include(::String) at /home/dave/.julia/v0.7/Compat/src/Compat.jl:3
 [4] eval(::Module, ::Expr) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:3
 [5] parse_module!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::Expr, ::Symbol, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:525
 [6] parse_expr!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::Expr, ::Symbol, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:458
 [7] parse_source!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::String, ::Symbol, ::Int64, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:404
 [8] parse_source!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::String, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:366
 [9] parse_source(::String, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:340
 [10] parse_pkg_files(::Symbol) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:304
 [11] watch_package_impl(::Symbol) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:571
 [12] (::getfield(Revise, Symbol("##9#10")){Symbol})() at ./event.jl:96
ERROR (unhandled task failure): could not open file /home/dave/Downloads/julia-eae7104bf9/bessel.jl
Stacktrace:
 [1] include_relative(::Module, ::String) at ./loading.jl:533
 [2] include at ./sysimg.jl:14 [inlined]
 [3] include(::String) at /home/dave/.julia/v0.7/SpecialFunctions/src/SpecialFunctions.jl:3
 [4] eval(::Module, ::Expr) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:3
 [5] parse_module!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::Expr, ::Symbol, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:525
 [6] parse_expr!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::Expr, ::Symbol, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:458
 [7] parse_source!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::String, ::Symbol, ::Int64, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:404
 [8] parse_source!(::Dict{Module,DataStructures.OrderedSet{Revise.RelocatableExpr}}, ::String, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:366
 [9] parse_source(::String, ::Module, ::String) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:340
 [10] parse_pkg_files(::Symbol) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:304
 [11] watch_package_impl(::Symbol) at /home/dave/.julia/v0.7/Revise/src/Revise.jl:571
 [12] (::getfield(Revise, Symbol("##9#10")){Symbol})() at ./event.jl:96

(omitting some deprecation warnings)

[kleinschmidt]

(This is on ed7dedc)

[timholy]

Interesting. That commit works for me on 0.6 but not on 0.7. On 0.7 I'm using teh/method_deletion and everything seems to work there. (However, the method deletion part isn't quite working yet, teh/callbacks might be a better choice for someone who doesn't want to develop Revise.)

The particular line that seems to be triggering the failure appears to be the fix to #43. I'd wager it's a consequence of JuliaLang/julia#23579.

[kleinschmidt]

teh/callbacks works for me, thanks!

[timholy]

Great. If you notice any problems with that branch, please do report them---that branch is the future of Revise's design, so it's great to have early testers. (I haven't merged it because the nightly builds are behind and don't have the necessary functionality yet.)