Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize regional & national public transit trains #471

Closed
3 tasks done
nvkelso opened this issue Jan 8, 2016 · 5 comments
Closed
3 tasks done

Categorize regional & national public transit trains #471

nvkelso opened this issue Jan 8, 2016 · 5 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Jan 8, 2016

In the transit layer, we just tossed in all route=train features. Let's characterize if it's a regional train or not so the styling and zoom ranges can be distinct.

UPDATE: Once we add the service property from the route relation, we can make the following selection: service IN ('high_speed', 'long_distance', 'international'). That set should have a min_zoom = 5, while the remainder should remain min_zoom = 6.

  • Include service in transit.jinja layer selection SQL
  • Update minimum zoom for "national" rail to 5 in the mz_calculate_transit_level SQL function.
  • Do we need to update the GIST index in apply-planet_osm_line.sql?
  • Connects with?: Add new transit layer features #469.
@nvkelso nvkelso added this to the v0.8.0 milestone Jan 8, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Jan 8, 2016

minimum zoom of national trains should change to 5, and regional trains should stay at 6

@nvkelso
Copy link
Member Author

nvkelso commented Mar 8, 2016

Related service tag discussion on OSM transit relations: #548 (comment)

@nvkelso
Copy link
Member Author

nvkelso commented Mar 11, 2016

From the discussion in #548:

Says @zerebubuth:

The transit layer currently contains the route / "line" relations, which cover the whole length of the route / named service / "line". The service attribute might be different from what you expect, especially if you're looking for short segments to drop. From my North America extract, here's a table of the count of features with distinct route and service values:

   route    |    service    |  num  
------------+---------------+-------
 train      | regional      | 13853
 train      | high_speed    |  6768
 train      | long_distance |  3092
 train      |               |  2347
 train      | commuter      |   218
 train      | international |    68
 train      | car           |    23
 train      | tourism       |     3

99% of the features are covered by service IN ('regional', 'high_speed', 'long_distance') OR service IS NULL.

@nvkelso
Copy link
Member Author

nvkelso commented Mar 11, 2016

Looks like there is a similar tag to service called passenger. TagInfo says, but those look to be rarely applied to route_relations.

One example is Amtrak California Zephyr.

  • passenger=national
  • service=long_distance

@nvkelso nvkelso changed the title Categorize regional & national public transit trains Categorize train service, adjust zoom for national rail Mar 11, 2016
@nvkelso nvkelso changed the title Categorize train service, adjust zoom for national rail Categorize regional & national public transit trains Mar 11, 2016
@rmarianski rmarianski self-assigned this Mar 17, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Mar 24, 2016

LGTM

screen shot 2016-03-23 at 23 43 54

screen shot 2016-03-23 at 23 43 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants