-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing school POIs #417
Comments
Well spotted! Looks like this isn't a regression, as these are mapped in a slightly unusual (but not wrong) way. For example, Arcata High is mapped as a named node imported from GNIS and an enclosing unnamed polygon added (slightly) later. Our bug was that we weren't using school POIs from points at all, and would only label them as landuse areas. Unfortunately, these landuse polygons are unnamed and don't generate labels. #419 adds the line required to include schools as POIs from points, after which I get: Arcata / BloomfieldZoom 15Zoom 16Sunnydale^H^H^H^H BreaZoom 15 |
I should add: because these are just points, we're missing important stuff for "importance", such as area. We should make a note to include this as a use-case for #348, as it's the same pattern. |
There were to have gone out in v0.5.2 release, but we missed a migration step so they're going out in v0.5.3 instead. |
Verified in prod. |
Sometimes we have landuse AOIs for them but we are dropping the label. Sometimes there is no landuse and it's just a POI in OSM, and we're dropping them. This feels like a regression.
Might be more widespread to other POI types?
This is a blocker for @IndyHurt next targeted editing post, we might want to consider another v0.5.x patch?
http://tangrams.github.io/cinnabar-style-more-labels/#15/40.8765/-124.0834
The text was updated successfully, but these errors were encountered: