Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min_zoom = 17 for generated address points #2032

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Add min_zoom = 17 for generated address points #2032

merged 2 commits into from
Dec 15, 2021

Conversation

nvkelso
Copy link
Member

@nvkelso nvkelso commented Dec 9, 2021 •
edited
Loading

Connects with #2023.

  • Update tests
  • Update docs just a bug fix

@nvkelso nvkelso added this to the v1.9.0 milestone Dec 9, 2021
@nvkelso nvkelso requested a review from tgrigsby-sc December 9, 2021 01:01
@nvkelso nvkelso mentioned this pull request Dec 15, 2021
Closed
@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

Relates to tilezen/tilequeue#402 which removes overstuffed features from tiles when their min_zoom is larger than the tile's nominal zoom. But if the min_zoom is null then they aren't pruned! This sets the min_zoom to 17 so the generated address points will get pruned.

@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

LGTM

I'm the author so I can't approve, @travisgrigsby you want to do those honors?

tgrigsby-sc
tgrigsby-sc approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@tgrigsby-sc tgrigsby-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the best test code I've ever witnessed in all my years of witnessing test code

@tgrigsby-sc tgrigsby-sc merged commit 4264b79 into master Dec 15, 2021
@peitili peitili deleted the nvkelso/2023-address-point-min_zooms branch December 16, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgrigsby-sc tgrigsby-sc tgrigsby-sc approved these changes

Assignees

@tgrigsby-sc tgrigsby-sc

Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nvkelso @tgrigsby-sc