Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate shield_text_length in roads layer #1979

Closed
nvkelso opened this issue Oct 28, 2021 · 1 comment
Closed

Calculate shield_text_length in roads layer #1979

nvkelso opened this issue Oct 28, 2021 · 1 comment
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 28, 2021

  1. While it's possible to calculate the text length of the shield_text property client side in both Tangram and MapboxGL, it's more performant to calculate that server side and include as a property on each relevant feature. Let's do that and call it shield_text_length as a post-processing step in queries.yaml with new transform function.
  2. Because shield_text can be either numerical or string we should always store it as string values to also illuminate type conversions client side.
  3. Shield artwork is between 1 and 6 chars long, so consider stripping out longer shields.
@nvkelso nvkelso added this to the v1.9.0 milestone Oct 28, 2021
@nvkelso
Copy link
Member Author

nvkelso commented Dec 15, 2021

Closed via #1991 and #1994.

@nvkelso nvkelso closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants