Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include deprecated WOF neigbourhoods (stale dump) #1808

Closed
nvkelso opened this issue Jan 28, 2019 · 10 comments
Closed

Don't include deprecated WOF neigbourhoods (stale dump) #1808

nvkelso opened this issue Jan 28, 2019 · 10 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Jan 28, 2019

@nvkelso nvkelso added this to the v1.7.0 milestone Jan 28, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Jan 28, 2019

image

@zerebubuth
Copy link
Member

We do support the edtf:deprecated tag, so the problem could either be a bug or that the WOF dump we're using is older than the deprecation was added to the record.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 28, 2019

Where is the WOF dump configured?

@zerebubuth
Copy link
Member

It's just a static dump that we download and restore as part of tileops. Headers on the dump suggest it was last updated around 12 Apr 2018, although it's possible it might be older than that.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 28, 2019

We should update the dump, then? Or really try for a "last good" distribution from WOF on DB setup?

Was it on a regular chron before, but then switching to RAWR tiles we just dump'd instead of doing a live load off the WOF distributions on DB setup?

See also:

@nvkelso nvkelso changed the title Don't include deprecated neigbourhoods Don't include deprecated WOF neigbourhoods (state dump) Jan 28, 2019
@zerebubuth
Copy link
Member

Yes, we used to have an automatic update process for WOF which ran on a schedule, the same way we were updating with diffs from OSM. Setting up a database from scratch was still a manual and difficult process for both OSM and WOF. When we moved to the global build, we automated the OSM part of that, but left the WOF setup for later.

In the meantime, it looks like the WOF data has become much easier to consume, so we might want to look at automating the import of the latest data.

@nvkelso
Copy link
Member Author

nvkelso commented Jan 29, 2019

Yes, let's tackle automating WOF import as part of the build.

@nvkelso nvkelso modified the milestones: v1.7.0, v1.8.0 Jan 30, 2019
@nvkelso nvkelso changed the title Don't include deprecated WOF neigbourhoods (state dump) Don't include deprecated WOF neigbourhoods (stale dump) Feb 19, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Feb 21, 2019

See also: tilezen/tilezen-tasks#4 and #1358

@nvkelso
Copy link
Member Author

nvkelso commented Feb 21, 2019

WOF = Who's On First for future SEO

@nvkelso
Copy link
Member Author

nvkelso commented Apr 22, 2019

Working.

@nvkelso nvkelso closed this as completed Apr 22, 2019
@ghost ghost removed the in review label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants