Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional landuse merging at low- and mid-zooms #1795

Closed
nvkelso opened this issue Jan 16, 2019 · 2 comments
Closed

Additional landuse merging at low- and mid-zooms #1795

nvkelso opened this issue Jan 16, 2019 · 2 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Jan 16, 2019

Followup to #1779 which started merging some types of landuse.

Upon further examination, even more merging can be had in the mid-zooms.

Child task of #1721.

@nvkelso nvkelso added this to the v1.7.0 milestone Jan 16, 2019
@nvkelso
Copy link
Member Author

nvkelso commented Jan 16, 2019

This table is updated from one that @zerebubuth provided me:

LEGEND

  • merged? = if it was merged in the earlier PR
  • do not merge = no transform suggested
  • suggest = a new kind transform suggested
  • notes = my notes back to Matt, or other explanations
kind merged? do not merge suggest note
aerodrome   x   yep, top level
airfield     aerodrome yep, there are a lot of these.
allotments urban_area     yep (though new z13+ makes irrelevant)
amusement_ride     urban_area yep (though new z15+ makes irrelevant)
animal     urban_area yep (though new z13+ makes irrelevant)
apron     aerodrome yep (though new z13+ makes irrelevant)
aquarium   x   no (new min_zoom is z12)
artwork     urban_area sure (no change at z11)
attraction     urban_area sure (no change at z12)
aviary     urban_area yep (though new z13+ makes irrelevant)
bare_rock barren     NO CHANGE
battlefield   x   NO CHANGE
beach   x   NO CHANGE
breakwater     barren "land" (but also change min_zoom to z13 to avoid situation)
bridge     urban_area yep (though new z13+ makes irrelevant)
caravan_site   x   no. unique feature, chaning z12+
carousel     urban_area yes
cemetery   x   CHANGE FROM EARLIER. no, better to have as green area
cinema     urban_area yes
city_wall   x   no, it's only z12+ already
college     urban_area no, remap to university
commercial urban_area     NO CHANGE
common     grassland yes
container_terminal     urban_area yes (z11+ anyhow)
cutline     forest updated: it's a line geometry anyhow?
dam     barren "land" but also updated min_zoom to 11+
danger_area     military good call; z9 in the data now
desert desert     NO CHANGE
dike     barren "land" but also updated min_zoom to 13+
dog_park     urban_area yep (though new z13+ makes irrelevant)
enclosure     urban_area yep (though new z13+ makes irrelevant)
farm farmland     NO CHANGE
farmland farmland     NO CHANGE
ferry_terminal     urban_area yep (hardly any of these)
footway     urban_area yep (though new z13+ makes irrelevant)
forest forest     NO CHANGE
fort     urban_area yep (new z11 is a little counter to that, but okay)
fuel     urban_area yep (though new z13+ makes irrelevant)
garden   x   no: it's different enough (plus green area); and only starts a few at zoom 12 with most coming in at zoom 13
generator     urban_area yep (z10 now, but let's just let the remapping happen)
glacier   x   NO CHANGE
golf_course   x   naw, it's it's own thing
grass grassland     NO CHANGE
grassland grassland     NO CHANGE
grave_yard     cemetery no, changed to cemetery (from urban area) as it's more "green area"
groyne     barren "land" but also updated min_zoom to 13+
harbour       SKIP as this got us into trouble in v1.5 – it's more a label area than a polygon; also changing to z13+
heath grassland     NO CHANGE
hedge     grassland yep (though new z13+ makes irrelevant)
hospital   x   no, it's own thing
industrial urban_area     NO CHANGE
land     barren "land" (no change in min_zoom from 9+)
library     urban_area yep (though new z13+ makes irrelevant)
meadow grassland     NO CHANGE
military   x   no, it's own thing
mud wetland     NO CHANGE
national_park   x   NO CHANGE
natural_forest     forest no (well, this has low feature count, there's a different bug for it)
natural_park     forest no (well, this has low feature count, there's a different bug for it)
natural_wood forest     NO CHANGE
nature_reserve   x   no, it's own thing
naval_base   x   no, it's own thing
orchard farmland     NO CHANGE
park   x   NO CHANGE
pedestrian     urban_area yep (though new z13+ makes irrelevant)
petting_zoo     urban_area yep (though new z13+ makes irrelevant)
picnic_site     grassland updated (though new z13+ makes irrelevant)
pier     urban_area yep (though new z13+ makes irrelevant)
pitch     urban_area yep
place_of_worship     urban_area yep (though this will make some rural churches odd, but they'll still receive POI correctly)
plant     urban_area yep
plant_nursery farmland     yep
playground     urban_area yep (though new z13+ makes irrelevant)
port     urban_area yep
port_terminal     urban_area yep
prison     urban_area yep (though this will make some rural prisons odd, but they'll still receive POI correctly)
protected_area   x   no – these are more like overlays
quarry barren     NO CHANGE
railway     urban_area sure
range     military okay. Also suggesting z11+ change; related to danger_area. might produce oddness.
recreation_ground   x   no, this is a green area, combined with z12+ change
recreation_track   x   no, this is a green area, combined with z12+ change
residential urban_area     NO CHANGE
resort   x   no, it's own thing (not many)
rest_area   x   no, it's own thing (not many)
retail urban_area     NO CHANGE
rock     barren yep
roller_coaster     urban_area yep (though new z15+ makes irrelevant)
runway     aerodrome yep (though new z13+ makes irrelevant)
sand desert     NO CHANGE
school   x   no, it's own thing (not many, only z12+ but generally z13+)
scree barren     NO CHANGE
scrub     grassland yep
service_area     urban_area yep
shingle barren     yep
sports_centre   x   no, green area and new z12+ (was 10) makes less problematic
stadium   x   no, green area and very few at low zooms
stone     barren yep
substation     urban_area yep
summer_toboggan   x   hard to know what to map to, let's make z13+ only instead
taxiway     aerodrome yep (though new z13+ makes irrelevant)
theatre     urban_area yep (though new z13+ makes irrelevant)
theme_park   x   no, it's own thing (few less than 13, but they're important)
tower     urban_area yep (though new z13+ makes irrelevant)
trail_riding_station   x   yikes (though new z13+ makes irrelevant)
tree_row     forest this is line geom, so irrelevant?
university   x   NO CHANGE
village_green urban_area     NO CHANGE
vineyard farmland     NO CHANGE
wastewater_plant     urban_area yep (though z12+ in future)
water_park     urban_area yep (though z13+ in future)
water_slide     urban_area yep (though z15+ in future)
water_works     urban_area sure
wetland wetland     NO CHANGE
wildlife_park   x   no, it's special / there aren't many
winery     farmland sure (though not many)
winter_sports   x   no, it's special
wood forest     NO CHANGE
works     urban_area sure
zoo   x   no, it's special

@nvkelso
Copy link
Member Author

nvkelso commented Feb 4, 2019

This is working.

@nvkelso nvkelso closed this as completed Feb 4, 2019
@ghost ghost removed the in review label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants