-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana: Add gRPC Received commands rate
panel
#8921
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: okJiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gRPC Received commands rate
gRPC Received commands rate
panel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8921 +/- ##
==========================================
+ Coverage 76.20% 76.25% +0.05%
==========================================
Files 461 461
Lines 70448 70407 -41
==========================================
+ Hits 53686 53690 +4
+ Misses 13402 13367 -35
+ Partials 3360 3350 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
"spaceLength": 10, | ||
"targets": [ | ||
{ | ||
"expr": "sum(rate(grpc_server_started_total{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\"}[1m])) by (instance, grpc_method)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about also adding the error rate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. But btw, it can't catch the error hide in the header, like this
Line 2071 in 2d970a6
Header: wrapErrorToHeader(pdpb.ErrorType_REGION_NOT_FOUND, |
Signed-off-by: okJiang <[email protected]>
"spaceLength": 10, | ||
"targets": [ | ||
{ | ||
"expr": "sum(rate(grpc_server_handled_total{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", instance=~\"$instance\", grpc_type=\"unary\", grpc_code!=\"OK\"}[1m])) by (grpc_method)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding one expr as unary total about ignoring grpc_code?
What problem does this PR solve?
Issue Number: Close #8920
What is changed and how does it work?
Check List
Tests
Release note