Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer: Use latest Fedora 40 image #6511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osteffenrh
Copy link
Contributor

Description

Since the CI is now running on Fedora 40, let's also switch over VSCode Devcontainer to use the same.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Untested - I have trouble getting the VSCode Devcontainer extension to work.
Can some regular VSCode user please try this?

Integration Instructions

Since the CI is now running on Fedora 40, let's also switch over
VSCode Devcontainer to use the same.

Signed-off-by: Oliver Steffen <[email protected]>
@tianocore-assign-reviewers
Copy link

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:


Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

@osteffenrh
Copy link
Contributor Author

@makubacki ?

@makubacki
Copy link
Member

@osteffenrh, you can open this easily without having VS Code installed.

  1. Go to the branch - https://github.com/osteffenrh/edk2/tree/devcontainer-f40
  2. Click "<> Code>. Click "Create codespace on ".
    image
  3. Wait for the codespace to be set up in your browser...
    image
  4. You should now be in the container.
    image
  5. You can run tests in the terminal at the bottom.
    • Setup (Clone)
      image
    • Update (Pull Binary Dependencies)
      image
    • Build / Test
      image

@osteffenrh
Copy link
Contributor Author

Interesting! I'll try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants