🐛 Update type annotations for show_default parameter and update docs for setting a "Custom default string"
#501
Conversation
|
📝 Docs preview for commit 5b02ed4 at: https://637303b6be5251630161321e--typertiangolo.netlify.app |
|
📝 Docs preview for commit 68a8592 at: https://639ce9cc18290c0ac6ff530c--typertiangolo.netlify.app |
svlandeg
added
bug
There was a problem hiding this comment.
Hi, thanks for the PR!
While we're pretty late to follow up on this, I believe this contribution still makes sense, as the feature is available for typer.Option - it's just not documented or correctly typed.
I hope you don't mind that I pushed to your branch directly to update it with the latest changes from master. I'll also include a new section for the documentation to showcase how this would work in a similar fashion as it does for typer.Argument.
|
📝 Docs preview for commit 2197f6d at: https://ed32ee88.typertiangolo.pages.dev |
|
Not a problem for the assistance in getting this merged. |
tiangolo
changed the title
show_default parameter and update docs for setting a "Custom default string"
|
Awesome, thanks @plannigan! 🤓 And thanks a lot @svlandeg for the review and tweaks! 🙇 This will be available in Typer 0.9.2 in the next few hours. 🚀 |
Fixes #158.