-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix display of default value for Enum parameters inside of a list, include docs and tests #473
Conversation
Ensures the enum `.value` is used in the generated help text for default Argument and Option values. Supports both isolated enum instances and lists or tuples of enum instances. Fixes fastapi#290
📝 Docs preview for commit 7f8eec1 at: https://635bd55aeef193174b41afb3--typertiangolo.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
===========================================
+ Coverage 96.24% 100.00% +3.75%
===========================================
Files 280 280
Lines 5942 5945 +3
===========================================
+ Hits 5719 5945 +226
+ Misses 223 0 -223 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 711cda5 at: https://639ce9f6d8175d0b722d6157--typertiangolo.netlify.app |
Any movement here? Also experiencing this. |
Sorry for the delay on this! We're going through the PR backlog and hope to look into this one soonish. Thanks for the contribution and your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution!
I ran some local tests and this looks good to me. The PR needs some tests though - I'll go ahead and add those by pushing to your branch directly, hope that's OK!
📝 Docs preview for commit d88bd0d at: https://8cb9f299.typertiangolo.pages.dev |
📝 Docs preview for commit bc9d853 at: https://cc392f29.typertiangolo.pages.dev |
📝 Docs preview for commit f4d781d at: https://d69ffac4.typertiangolo.pages.dev |
📝 Docs preview for commit 8554833 at: https://630964bb.typertiangolo.pages.dev |
Ok - I'll leave this up for further review by Tiangolo. Note that this PR now includes 2 main changes:
|
📝 Docs preview for commit 9817520 at: https://f9bca2b0.typertiangolo.pages.dev |
Ensures the enum
.value
is used in the generated help text for default Argument and Option values. Supports both isolated enum instances and lists or tuples of enum instances.Did local testing with existing scripts/pytest.sh and all passed.
Fixes #290