-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: supporting future unstable versions #1449
Conversation
I don’t think it’s a good idea to do this. To test alpha beta thing, we would need to release on |
Probably this should be merged into EDIT I already created |
What is the difference between supporting the next or stable version of a future release which hasn't been tested at all? if a library fails with 14.0.0-next.x it will fail with 14.0.0 too. |
Our policy has been always targeting stable version of Jest + Angular. We would like to keep that always. In the case of supporting unstable version, it should be considered under |
Isn't that odd? You target to support stable versions which wasn't actually tested for compatibility. I think, what you describe requires to add a version boundary, like >=11 <12, so anyone would know that stable 12 hasn't been tested yet and might bring unexpected failures and side effects. |
@satanTime it's just more work for us to support next or release candidates as well and we always decided against it.
That might not be true. There could be a small change between 14.0.0-next.x and 14.0.0 which makes it easier for us. Note that we partially rely on internal angular APIs. |
I agree with setting supported version range. It's a good thing to do, like now it would be >=11 <14 |
That also sounds good to me. Should I update the PR to add <14? |
Sure let’s do like that |
Summary
Allows to work with alpha, beta, rc etc.
Test plan
CI/CD doesn't fail, no regressions
Does this PR introduce a breaking change?
Other information
The plan is to avoid errors like: