Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) react example seems outdated and not very clear #2755

Open
augustinasrce opened this issue Dec 5, 2024 · 1 comment · May be fixed by #2756
Open

(doc) react example seems outdated and not very clear #2755

augustinasrce opened this issue Dec 5, 2024 · 1 comment · May be fixed by #2756
Assignees
Labels
documentation Improvements or additions to documentation p2 Medium priority

Comments

@augustinasrce
Copy link
Contributor

Change in the documentation

in README.md links are not working

https://github.com/thomaspoignant/go-feature-flag/blob/main/examples/openfeature_react/react-app/src/App.tsx

Implementation it self is not linted/formatted properly
Initialization of OpenFeature sdk is a bit confusing and could be better.

maybe reusing this would be beneficial
https://github.com/open-feature/js-sdk/blob/main/packages/react/README.md

@augustinasrce augustinasrce added documentation Improvements or additions to documentation needs-triage A priority should be added to the issue labels Dec 5, 2024
@thomaspoignant thomaspoignant added p2 Medium priority and removed needs-triage A priority should be added to the issue labels Dec 5, 2024
@thomaspoignant thomaspoignant linked a pull request Dec 6, 2024 that will close this issue
3 tasks
@thomaspoignant
Copy link
Owner

Yes it could definitely be better, but can you tell me exactly what you don't like?
The example is very close to the documentation you have linked.

I have open a PR for:

  • Implementation it self is not linted/formatted properly
  • Fixing the links.

Can you tell me a bit more to make it better.

PR is #2756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p2 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants