Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Object.dirname is deprecated. #386

Closed
mathuin opened this issue Jun 15, 2017 · 7 comments
Closed

Object.dirname is deprecated. #386

mathuin opened this issue Jun 15, 2017 · 7 comments
Assignees

Comments

@mathuin
Copy link

mathuin commented Jun 15, 2017

Argument to path.dirname must be a string

Object.dirname (/opt/atom/resources/app/src/electron-shims.js:9:10)
new LogParser (/home/jmt/.files/atom/.atom/packages/latex/lib/parsers/log-parser.js:61:42)
KnitrBuilder.getLogParser (/home/jmt/.files/atom/.atom/packages/latex/lib/builder.js:83:14)
KnitrBuilder.parseLogFile (/home/jmt/.files/atom/.atom/packages/latex/lib/builder.js:68:27)
KnitrBuilder.parseLogAndFdbFiles (/home/jmt/.files/atom/.atom/packages/latex/lib/builder.js:181:12)
Composer.<anonymous> (/home/jmt/.files/atom/.atom/packages/latex/lib/composer.js:279:17)
@yitzchak
Copy link
Collaborator

Thanks for the issue report. What version of the latex package are you using?

@mathuin
Copy link
Author

mathuin commented Jun 15, 2017

0.44.0 is the version I am using.

@yitzchak
Copy link
Collaborator

yitzchak commented Jun 19, 2017

I have not been able to reproduce this yet. Do you have an example file that this reliably happens with? Also, can us you give a run-down of your settings are for the latex package?

@mathuin
Copy link
Author

mathuin commented Jun 19, 2017

I was unable to reproduce the issue myself.

"*":
  core:
    customFileTypes:
      "text.tex.latex": [
        "Rnw"
      ]
  latex:
    engine: "xelatex"

That's the only bit in my config.json that appears to be relevant.

@yitzchak
Copy link
Collaborator

Ok. I think it might have happened because the log file was there, but the generated LaTeX file was not. I'll stick in a guard conditional just in case and close the issue afterward.

Just FYI, there is a syntax package (language-knitr) for knitr so you don't have to use the customFileTypes hack if you don't want to.

@mathuin
Copy link
Author

mathuin commented Jun 19, 2017

Thanks for the pointer! I'm giving that package a try now -- so far all I see is the highlighting from the start lines, but I'm going to check out the docs to see what more it offers. Thank you also for finding the problem and fixing it!

@yitzchak
Copy link
Collaborator

It depends on language-latex so you will need to have that installed also.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants