This repository has been archived by the owner on Aug 14, 2022. It is now read-only.
Refocus Atom on Evince Reverse Sync #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmohns
reviewed
Mar 24, 2017
lib/openers/evince-opener.js
Outdated
| atom.focus() | ||
| atom.workspace.open(filePath).then(editor => editor.setCursorBufferPosition(point)) |
There was a problem hiding this comment.
Why do you focus first and then sync? I tried out both and either seems to work. But me personally feel that syncing first and then focus feels a bit more natural. Is there a technical motivation behind it?
(In the case of first focus and sync I could sometimes see the content of my editor windows move around.)
PS: This is so awesome.
There was a problem hiding this comment.
It probably doesn't really matter. Focusing first gives some visual cues to the movement of the cursor, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add window focus on reverse sync for Evince.
Resolves #354