-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow expires_in equals 0 #606
Conversation
2 similar comments
Thanks, @artad. This seems to comply with the definition of "expires_in" in appendix A.14. of RFC 6749:
It can be
Any concerns, @shadowhand? |
LGTM. |
Thanks! |
Thanks for your attention |
This breaks the code tho, As is, it yields the following error
|
Some services (http://vk.com, no expiration) return "expires_in" equals 0 and no "expires".
In this case:
!empty($options['expires_in']) == FALSE
!empty($options['expires']) == FALSE
and expires property remain NULL