Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Packages which contain src and symbols #46

Open
romerod opened this issue Sep 5, 2017 · 1 comment
Open

Packages which contain src and symbols #46

romerod opened this issue Sep 5, 2017 · 1 comment

Comments

@romerod
Copy link

romerod commented Sep 5, 2017

I've just stumbled upon a package which contains sources and symbols and is found on the nuget.org feed: Appccelerate.StateMachine 4.4.0

The following code in the PackagesController.PutPackage makes it impossible to publish that package:

            if (package.HasSourceAndSymbols())
            {
                var response = Request.CreateResponse(HttpStatusCode.RedirectKeepVerb);
                response.Headers.Location = new Uri(Url.Link(RouteNames.Symbols.Upload, null), UriKind.RelativeOrAbsolute);
                return response;
            }

As it's not clear from the nuget docs whether the package is publishable and you might rely on that feature I open this issue instead of sending a PR.

Kind regards
Daniel

@chriseldredge
Copy link

This problem was noted back in 2015. See http://chris.eldredge.io/blog/2015/01/05/nuget-symbols-and-aspnet-vnext/. Given that Klondike now has a special endpoint for handling symbol packages, the code that you reference can be removed. Some ancient consumers of Klondike that push symbol packages may break in the next version, but the fix should be relatively easy to implement.

A PR removing the above condition would be welcomed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants