Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a Base layer for Settings and Commerce fieldsets #2922

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

bordoni
Copy link
Member

@bordoni bordoni commented Feb 3, 2024

🗒️ Description

Include Telemetry data about how we are using Event Tickets to improve deprecation of old code and guide proper feature development.

It for sure doesn't include all the data points we want but it creates a small setup start pushing that data.

This separates the value of each one of our data-points in a way that we can add tests, which I haven't gotten to I ran out of time this Friday, only had about 1h to actually do code today.


Once we include the change to the Sniffer we should avoid problems with @inheritDoc
stellarwp/coding-standards#22

🎥 Artifacts

https://i.bordoni.me/tNrzrWXQ

✔️ Checklist

  • I've included a changelog entry in the readme.txt file.
  • My code is tested.

@bordoni bordoni added code review Status: requires a code review. needs release Needs an associated release in Jira before merging. needs tests Needs tests before merging. innovation Project associated with 20% time innovations. labels Feb 3, 2024
@bordoni bordoni self-assigned this Feb 3, 2024
Copy link
Contributor

@tec-bot tec-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

src/Tickets/Site_Health/Fieldset/Settings.php|41 col 22| WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 4 space(s) between "'id'" and double arrow, but found 1.
src/Tickets/Site_Health/Fieldset/Settings.php|86 col 1| PSR2.Files.EndFileNewline.NoneFound
Expected 1 newline at end of file; 0 found
src/Tickets/Site_Health/Provider.php|46 col 8| Squiz.Commenting.FunctionComment.EmptyThrows
Comment missing for @throws tag in function comment
src/Tickets/Site_Health/Provider.php|48 col 8| Squiz.Commenting.FunctionComment.MissingParamComment
Missing parameter comment

src/Tickets/Site_Health/Contracts/Fieldset_Abstract.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Contracts/Fieldset_Abstract.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Contracts/Fieldset_Abstract.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Fieldset/Settings.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Fieldset/Settings.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Fieldset/Settings.php Show resolved Hide resolved
src/Tickets/Site_Health/Fieldset/Settings.php Outdated Show resolved Hide resolved
src/Tickets/Site_Health/Fieldset/Settings.php Outdated Show resolved Hide resolved
@bordoni bordoni removed the needs tests Needs tests before merging. label Feb 4, 2024
@bordoni bordoni assigned redscar and unassigned bordoni May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review. innovation Project associated with 20% time innovations. needs release Needs an associated release in Jira before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants