Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release mode, not use log/recovery middleware #376

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Use release mode, not use log/recovery middleware #376

merged 1 commit into from
Sep 13, 2018

Conversation

thinkerou
Copy link
Contributor

No description provided.

@waghanza
Copy link
Collaborator

Framework (Middleware) Average 50% percentile 90% percentile 99% percentile 99.9% percentile Standard deviation
here gin 12.65 ms 10.99 ms 20.16 ms 39.79 ms 221.53 ms 7841.00
master gin 52.95 ms 29.85 ms 144.86 ms 236.48 ms 526.27 ms 60143.00

@waghanza waghanza merged commit 9ce2ad6 into the-benchmarker:master Sep 13, 2018
@waghanza
Copy link
Collaborator

@thinkerou Thanks for you contribution

If I may ask you a question ... how can I specify version to use (instead of using master in golang) ?

@thinkerou
Copy link
Contributor Author

@waghanza go get -u github.com/gin-gonic/[email protected], right?

@waghanza
Copy link
Collaborator

@thinkerou ok, so I could say that with the implementation in https://github.com/waghanza/http-benchmark/blob/version_display/go/gin, I use the 1.3 version of gin ?

PS : I have no golang skills

@thinkerou
Copy link
Contributor Author

thinkerou commented Sep 14, 2018

@waghanza I am sorry, I said go get -u github.com/gin-gonic/[email protected] is wrong, it should be govendor fetch github.com/gin-gonic/[email protected], so it will install govendor firstly.

If you don't install govendor, you should use go get gopkg.in/gin-gonic/gin.v1, so am other go web framework. when I have time I am willing commit one pr for go.

@waghanza
Copy link
Collaborator

@thinkerou sure, I'd be happy to learn / add this ❤️

@appleboy
Copy link
Member

@thinkerou Don't use gopkg.in service any more :)

@thinkerou
Copy link
Contributor Author

@appleboy OK, thanks!

waghanza pushed a commit to qti3e/web-frameworks that referenced this pull request Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants