-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display version on results #317
Conversation
@tbrand and all Using |
551ca63
to
7ccd228
Compare
@tbrand @OvermindDL1 @aichholzer I've added a sample resultset here => https://github.com/waghanza/http-benchmark/tree/version_display#results What do you think ? PS : Display version of language will be added after cloudification, cause language version (at least for some languages such as |
go/gin/Dockerfile
Outdated
@@ -3,7 +3,7 @@ FROM golang | |||
WORKDIR /usr/src/app | |||
COPY main.go . | |||
|
|||
RUN go get -u github.com/gin-gonic/gin | |||
RUN go get -u github.com/gin-gonic/gin@1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't work in golang container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add source code in the vendor. Can I create a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, as I never done (production-ready) go app, I do not understand what you want to do, but feel free to open a separated PR
/ issue
, we will discuss about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #377
@OvermindDL1 I have re-made result (https://github.com/waghanza/http-benchmark/tree/version_display#results) |
Well the version it is using is |
@OvermindDL1 ok, I think we'd better have to fix version in the build file |
README.md
Outdated
@@ -82,64 +82,68 @@ CPU Cores: 4 | |||
:two: rocket (rust) | |||
|
|||
|
|||
:three: rack-routing (ruby) | |||
:three: laravel (php) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't magic that the laravel framework wins a third of the list.
@appleboy sure ... The results are not representative yet (cause of docker). Probably for Xmas / end of year, results will be produced of digitalocean (si Docker fluctuation will be thrown away) |
* add prism * fix dockerfile * use latest beta instead of master on prism
* separate benchmark list * use an external configuration file to list frameworks * use an external configuration file to list frameworks * add framework version on each table * add framework list * fix version for node implementations * fix version for php implementations * fix wrong commit * fix version for python implementations * add url to target (website or source code access) * update framework listing, only elixir is commented * update framework listing, only elixir is commented * restore elixir (phoenix / plug) * upgrade amber to 0.9 * update roda * update rails * Introduce prism (the-benchmarker#340) * add prism * fix dockerfile * use latest beta instead of master on prism * fix version display (to be refactor) * update existing frameworks and add contributions :heart * fix connections level, 1000 is enough * remove elixir framework * wrong print bind params * fix go framework version * add resultset * remove duplicate key on build file * add prism * fix mofuw version * update laravel * fix evhtp version * add link for each framework * full resultset * use th instead of percentage sign (for percentile) * add beego * upgrade some versions * full resultset
Hi,
This
PR
add version, onlyX.Y
, for each frameworks implementations.The language version will be added later, the language version depends on :
aws
,gcp
,azure
,digitalocean
...)debian
,centos
...)Regards,