Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display version on results #317

Merged
merged 35 commits into from
Sep 22, 2018
Merged

Display version on results #317

merged 35 commits into from
Sep 22, 2018

Conversation

waghanza
Copy link
Collaborator

@waghanza waghanza commented Aug 1, 2018

Hi,

This PR add version, only X.Y, for each frameworks implementations.

The language version will be added later, the language version depends on :

  • Which provider is use (aws, gcp, azure, digitalocean ...)
  • Operating system (debian, centos ...)
  • ...

Regards,

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 3, 2018

@tbrand and all gophers here How can I display version in golang ?

Using import directly download from master. How can I represent version number ?

@waghanza waghanza mentioned this pull request Aug 3, 2018
@waghanza waghanza force-pushed the master branch 3 times, most recently from 551ca63 to 7ccd228 Compare September 12, 2018 14:07
@waghanza waghanza changed the title [WIP] Display version on results Display version on results Sep 12, 2018
@waghanza
Copy link
Collaborator Author

waghanza commented Sep 12, 2018

@tbrand @OvermindDL1 @aichholzer I've added a sample resultset here => https://github.com/waghanza/http-benchmark/tree/version_display#results

What do you think ?

PS : Display version of language will be added after cloudification, cause language version (at least for some languages such as ruby depends on cloud provider / os)

@@ -3,7 +3,7 @@ FROM golang
WORKDIR /usr/src/app
COPY main.go .

RUN go get -u github.com/gin-gonic/gin
RUN go get -u github.com/gin-gonic/gin@1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't work in golang container.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add source code in the vendor. Can I create a new PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, as I never done (production-ready) go app, I do not understand what you want to do, but feel free to open a separated PR / issue, we will discuss about that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #377

@waghanza
Copy link
Collaborator Author

@OvermindDL1 I have re-made result (https://github.com/waghanza/http-benchmark/tree/version_display#results)
How can I fix version for evhtp ?

@OvermindDL1
Copy link
Collaborator

Well the version it is using is 1.2.16-p4 and that won't change until the huntergate is updated in it's dependency block, so that won't be changing. You can always query the version from the build file (to write out to a file or whatever) via HUNTER_libevhtp_VERSION version of course.

@waghanza
Copy link
Collaborator Author

@OvermindDL1 ok, I think we'd better have to fix version in the build file

README.md Outdated
@@ -82,64 +82,68 @@ CPU Cores: 4
:two: rocket (rust)


:three: rack-routing (ruby)
:three: laravel (php)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't magic that the laravel framework wins a third of the list.

@waghanza
Copy link
Collaborator Author

@appleboy sure ... The results are not representative yet (cause of docker).
The only thing thanks will not change is the way how infos are shown.

Probably for Xmas / end of year, results will be produced of digitalocean (si Docker fluctuation will be thrown away)

@waghanza waghanza merged commit bdae539 into the-benchmarker:master Sep 22, 2018
@waghanza waghanza deleted the version_display branch September 22, 2018 08:48
waghanza added a commit to qti3e/web-frameworks that referenced this pull request Oct 5, 2018
* separate benchmark list

* use an external configuration file to list frameworks

* use an external configuration file to list frameworks

* add framework version on each table

* add framework list

* fix version for node implementations

* fix version for php implementations

* fix wrong commit

* fix version for python implementations

* add url to target (website or source code access)

* update framework listing, only elixir is commented

* update framework listing, only elixir is commented

* restore elixir (phoenix / plug)

* upgrade amber to 0.9

* update roda

* update rails

* Introduce prism (the-benchmarker#340)

* add prism

* fix dockerfile

* use latest beta instead of master on prism

* fix version display (to be refactor)

* update existing frameworks and add contributions :heart

* fix connections level, 1000 is enough

* remove elixir framework

* wrong print bind params

* fix go framework version

* add resultset

* remove duplicate key on build file

* add prism

* fix mofuw version

* update laravel

* fix evhtp version

* add link for each framework

* full resultset

* use th instead of percentage sign (for percentile)

* add beego

* upgrade some versions

* full resultset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants