Don't needlessly allocate in Rocket code #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to show the potential change here. Feel free to implement it if you'd like. :) |
|
Makes sense! 🙈 Any possible improvements should definitely be added, I'm all for adding this change. |
Absolutely💯 |
Merged
|
Have the benchmarks been rerun with this? I've run the benchmarks locally, and I see timing on the order of Iron/Nickel, not the 2.5x worse value shown in the image. |
|
Others have noticed a certain discrepancy regarding rocket's stats as well, but I don't think anybody knows why it differs. On my machine it's definitely comparable to iron and nickel as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.