vapor 2 -> 3 #199
Merged
vapor 2 -> 3 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @tanner0101, Thanks for updating However you are using a branch, not a tag. I'll rather wait until |
|
@waghanza yes sorry should have mentioned that. The tag will be coming today, so wanted to have this PR ready 👍 |
|
@tanner0101 any update ? |
|
@waghanza just updated to 3.0.0 official release. 👍 |
|
@tanner0101 The Could you confirm that the commit I have made is OK ? |
tanner0101
commented
May 11, 2018
swift/vapor/Dockerfile
Outdated
| @@ -6,4 +6,4 @@ COPY Package.swift main.swift ./ | |||
|
|
|||
| RUN swift build -c release | |||
|
|
|||
| CMD .build/release/server serve -e prod -h 0.0.0.0 -p 3000 | |||
| CMD .build/release/server serve --hostname 0.0.0.0 --port 3000 --env prod | |||
There was a problem hiding this comment.
Oops, that should have been -H (capital). The change you made works, too. Thanks!
There was a problem hiding this comment.
FWIW, you could also write this as:
CMD .build/release/server serve -b 0.0.0.0:3000 -e prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.