Add rust/rocket #19
Merged
Add rust/rocket #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want it might also be an option to specify the rust toolchain via the make and neph targets. It would probably rely on the user having rust installed via rustup, but since that's how most people install rust that should be a given. |
tbrand
requested changes
May 7, 2017
README.md
Outdated
| @@ -20,6 +20,7 @@ | |||
| - [IRON](https://github.com/iron/iron) | |||
| - [nickel.rs](https://github.com/nickel-org/nickel.rs) | |||
| - node | |||
| - [Rocket](https://rocket.rs) | |||
There was a problem hiding this comment.
Oh whoops, how did that happen? o.O
tbrand
approved these changes
May 7, 2017
|
Thanks for this!!:tada: |
|
Thanks for the merge 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rocket to the list of Rust frameworks.
Running the client seems to work fine. I haven't run the benchmarker though.
Only downside is that Rocket currently requires nightly rust to be built because of feature flags. Not sure if this is a deal-breaker for you, but it works just fine otherwise.