-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerify2 #187
Dockerify2 #187
Conversation
* lint neph config file * lint actual config file * disable line length verification (temporary)
This reverts commit ba53886. Since docker image was updated @see #180 (comment)
@waghanza I've pushed my patches at here. Thanks! |
Hmm... This is a lie:
It's only using a single thread worth of parallel requests as it's still using the crystal benchmarker, which is single-threaded parallel work only (Crystal is not multi-core). It can use multiple-threads to perform requests sure, but it will only use a single core as they become serialized (thus slower than just a single thread anyway). So something is borked... |
I really totally don't understand why you say I lied. Please stop saying like that strong words. |
No no! I'm not saying you lied at all! I'm stating that the display from the output is lying about what it is actually doing (it implies it is using 9 threads worth of power to siege the servers, which it is not doing), plus I don't think that was your code anyway. ^.^ |
Oh OK, sorry for that. Let me discuss about it at another place. 😄 |
Speaking of, have you thought to set up gitter for this repo or do you prefer all chat to be in issues-only for visibility reasons? |
@tbrand If ok, I can open / create a gitter channel |
@OvermindDL1 done it 👍 I'll PR about this next week |
@waghanza What's going on? |
I'll merge this after test (somewhere around tomorrow) |
* use docker to isolate hosts * run flask on gunicorn (temporary solution) * build on ci (only to ensure build could run) * fix style (underscore for large numbers) * use shards to release all binaries (client,benchmarker) * remove unused directory * uniformize rubies dockerfile * enable to specify (or not) frameworks to benchmark * fix style (underscore for large numbers) * allow docker host * re-enable django (in a container) * enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux * dockerize iris * fix jester containerization * re-enable rack-routing * re-enable lucky * re-enable amber * re-enable spider-gazelle * Lint yaml (the-benchmarker#166) * lint neph config file * lint actual config file * disable line length verification (temporary) * re-enable vapor * use docker to isolate hosts * fix style (underscore for large numbers) * use shards to release all binaries (client,benchmarker) * enable to specify (or not) frameworks to benchmark * enable to specify (or not) frameworks to benchmark * re-enable django (in a container) * enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux * re-enable actix * update dependencies * fix actix availability * re-enable rust frameworks > iron > nickel > rocket * upgrade dependencies * fix listening ip * upgrade dependencies * use rust nightly to cimple rocket * force shards to install ameba binary * keep crystal code / yaml files clean * use production mode * lint * fix assets compilation * use --no-debug flag on compilation * fix version * fix version * remove unnecessary code on lucky * use production env mode on lucky * fix nickel running into dockerf * fix mofuw in docker * re-enable japronto * re-enable sanic * re-enable tornado * re-enable node frameworks (polka / express) * remove Package.pins (see the-benchmarker#172) * update to last major * re-enable swift frameworks (kitura / perfect / vapor) * re-enable tornado & sanic * install neph cli tool on compilation * re-enable elixir frameworks (plug & elixir) * re-enable libevhtp * fix version conflict on amber compilation * add scala framework (akkahttp) * re-enable mofuw * re-enable c# (.net) framework * fix travis config (duplicate key) * upgrade docker image * restore evhtp source files * do not start containers with neph, but on-the-fly * re-enable node frameworks * Revert "upgrade docker image" This reverts commit ba53886. Since docker image was updated @see the-benchmarker#180 (comment) * increase sleeping time to wait container starting * fix aspnetcore container * use make to build containers sequentially * crystal tools are compiled with shards intsead of make * fix * avoid using lock files * fix rocket build (needs nighlty) * fix lucky build
Sorry, what? Do you know that neither |
@AlexWayfer yeah the After |
OK, thank you! |
I've fix the #180.
Now it's perfectly working with
bin/benchmarker -r 1
OS: Darwin (version: 17.3.0, arch: x86_64)
CPU Cores: 8
threads: 9, requests: 1