feat: make @testing-library/dom dependency optional
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 602 611 +9
Branches 172 173 +1
=========================================
+ Hits 602 611 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MichaelDeBoey
approved these changes
Aug 26, 2023
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Makes our dependency on
@testing-library/domoptional.Why:
@testing-library/domis a sizable dependency to pull in just for the name of the queries which are a pretty static thing, and it is possible to usejest-domwithout@testing-library; it also conflicts with Yarn PnP when using a more specific variant as it's recommended to not have@testing-library/domas a dependency in that case.How:
Using the same logic to what we do in
eslint-plugin-jestfor extending@typescript-eslint/eslint-pluginrules - in this case, we have a default list of queries we expect to exist which we use if we're not able to get a more up-to-date list via requiring@testing-library/dom.Note that I have purposely not added support for checking for more specific variants as part of this change; I plan to do that as a follow-up once this has been landed.
Checklist: