We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I wish RenderComponentOptions were typed a little more. I have seen something along the lines of:
RenderComponentOptions
const routingMock = new RouterMock() const ourPageMenuButtons: MenuButton[] = [{ name: 'testName', path: 'testPath' }, { name: 'testName2', path: 'testPath2' }, { name: 'testName3', path: 'testPath3' }]; await render(MenuComponent, { componentProviders: [ {provide: Router, usevalue: routingMock} ], componentProperties: { pageMenuButtons: ourPageMenuButtons } });
useValue isn't written correctly, there is no error in the static code analysis, because the actual type is just any[].
useValue
any[]
Maybe we can change it to something like:
export interface ProviderInterface { provide: any; useValue: any; multi?: boolean; } ... RenderComponentOptions imports?: Array<Type<any>|ModuleWithProviders<unknown>|any[]>; providers?: Array<ProviderInterface | TypeProvider | EnvironmentProviders>; componentProviders?: Array<ProviderInterface | TypeProvider | EnvironmentProviders>;
What do you think?
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Hi,
I wish
RenderComponentOptions
were typed a little more. I have seen something along the lines of:useValue
isn't written correctly, there is no error in the static code analysis, because the actual type is justany[]
.Maybe we can change it to something like:
What do you think?
The text was updated successfully, but these errors were encountered: