Fixing a couple of plots to use initial block height

[john-science]

What is the change?

Moving certain plots to use the BOL block height.

Why is the change being made?

This is to improve consistency in our block plots.

close #1158

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify any new/changed code.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes have been updated if necessary.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[keckler]

This looks fine, but I have not gotten a chance to test it with my real models.

Are you trying to get this merged within the coming week-ish? I don't have any strong need to get it merged for the coming release, but what are your priorities?

[john-science]

@drewj-tp @keckler I know we're all busy, etc. So that's fine.

But I DID just get approval to merge this, if it gets Approved.

[keckler]

Trying to test now

[keckler]

Unfortunately, this does not appear to work right now. When I test it out on some dummy problem, I'm still getting the hot heights printed by plotAssemblyTypes() when it is called during the BOL reports interface (via newReportUtils.insertCoreAndAssemblyMaps()).

The issue appears to be that plotAssemblyTypes() is called based on blueprints, and block definitions in blueprints don't appear to have parents, and thus we get kicked into the except of the try/except clause that you added.

I think that, if we passed actual assemblies that have been constructed from the blueprints, then this will work? Let me know if that doesn't make sense.

[keckler]

I think that this PR will break an existing usage where hot heights are desired.

armi/armi/reactor/converters/uniformMesh.py

Lines 958 to 992 in 68268c1

	def plotConvertedReactor(self):
	"""Generate a radial layout image of the converted reactor core."""
	bpAssems = list(self.convReactor.blueprints.assemblies.values())
	assemsToPlot = []
	for bpAssem in bpAssems:
	coreAssems = self.convReactor.core.getAssemblies(bpAssem.p.flags)
	if not coreAssems:
	continue
	assemsToPlot.append(coreAssems[0])
	# Obtain the plot numbering based on the existing files so that existing plots
	# are not overwritten.
	start = 0
	existingFiles = glob.glob(
	f"{self.convReactor.core.name}AssemblyTypes" + "*" + ".png"
	)
	# This loops over the existing files for the assembly types outputs
	# and makes a unique integer value so that plots are not overwritten. The
	# regular expression here captures the first integer as AssemblyTypesX and
	# then ensures that the numbering in the next enumeration below is 1 above that.
	for f in existingFiles:
	newStart = int(re.search(r"\d+", f).group())
	if newStart > start:
	start = newStart
	for plotNum, assemBatch in enumerate(
	iterables.chunk(assemsToPlot, 6), start=start + 1
	):
	assemPlotName = f"{self.convReactor.core.name}AssemblyTypes{plotNum}-rank{armi.MPI_RANK}.png"
	plotting.plotAssemblyTypes(
	self.convReactor.blueprints,
	assemPlotName,
	assemBatch,
	maxAssems=6,
	showBlockAxMesh=True,
	)

That block of code calls to plotAssemblyTypes() to demonstrate the impact of the uniform mesh generator. In that circumstance, the hot heights are probably desired in the plots.