Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event_bus_name to aws_cloudwatch_event_rule #12886

Conversation

alexanderkalach
Copy link
Contributor

@alexanderkalach alexanderkalach commented Apr 18, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9330

Release note for CHANGELOG:

resource/aws_cloudwatch_event_rule: Add `event_bus_name`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchEventRule'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventRule -timeout 120m
=== RUN   TestAccAWSCloudWatchEventRule_basic
=== PAUSE TestAccAWSCloudWatchEventRule_basic
=== RUN   TestAccAWSCloudWatchEventRule_role
=== PAUSE TestAccAWSCloudWatchEventRule_role
=== RUN   TestAccAWSCloudWatchEventRule_description
=== PAUSE TestAccAWSCloudWatchEventRule_description
=== RUN   TestAccAWSCloudWatchEventRule_pattern
=== PAUSE TestAccAWSCloudWatchEventRule_pattern
=== RUN   TestAccAWSCloudWatchEventRule_prefix
=== PAUSE TestAccAWSCloudWatchEventRule_prefix
=== RUN   TestAccAWSCloudWatchEventRule_tags
=== PAUSE TestAccAWSCloudWatchEventRule_tags
=== RUN   TestAccAWSCloudWatchEventRule_IsEnabled
=== PAUSE TestAccAWSCloudWatchEventRule_IsEnabled
=== CONT  TestAccAWSCloudWatchEventRule_basic
=== CONT  TestAccAWSCloudWatchEventRule_prefix
=== CONT  TestAccAWSCloudWatchEventRule_IsEnabled
=== CONT  TestAccAWSCloudWatchEventRule_tags
=== CONT  TestAccAWSCloudWatchEventRule_description
=== CONT  TestAccAWSCloudWatchEventRule_role
=== CONT  TestAccAWSCloudWatchEventRule_pattern
--- PASS: TestAccAWSCloudWatchEventRule_prefix (39.03s)
--- PASS: TestAccAWSCloudWatchEventRule_role (58.84s)
--- PASS: TestAccAWSCloudWatchEventRule_pattern (73.82s)
--- PASS: TestAccAWSCloudWatchEventRule_description (74.00s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (76.13s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (104.42s)
--- PASS: TestAccAWSCloudWatchEventRule_IsEnabled (106.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	106.479s
...

@alexanderkalach alexanderkalach requested a review from a team April 18, 2020 20:41
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Apr 18, 2020
@gdavison gdavison self-assigned this Oct 13, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Oct 14, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants