feat(TPG>=5.36)!: add confidential_instance_type to instance_template module

[arthurlapertosa]

add confidential_instance_type to instance_template module, with example and tests

[daniel-cit]

/gcbrun

[daniel-cit]

@apeabody Could you PTAL ?

[apeabody]

Thanks for the contribution @arthurlapertosa!

Please see the notes below:

[apeabody]

/gcbrun

[apeabody]

FYI @arthurlapertosa

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/instance_template/README.md /tmp/tmp.4PKCCzT0D4/generate_docs/workspace/modules/instance_template/README.md
23c23
< | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `""` | no |
---
> | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `null` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

[arthurlapertosa]

FYI @arthurlapertosa

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/instance_template/README.md /tmp/tmp.4PKCCzT0D4/generate_docs/workspace/modules/instance_template/README.md
23c23
< | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `""` | no |
---
> | confidential\_instance\_type | Defines the confidential computing technology the instance uses. If this is set to "SEV\_SNP", var.min\_cpu\_platform will be automatically set to "AMD Milan". | `string` | `null` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

Sorry, I forgot to update the documentation after changing the default value to null. Just did it.

[apeabody]

/gcbrun

[erlanderlo]

SEV vs SEV_SNP

[arthurlapertosa]

@apeabody could you please trigger the workflows?

[apeabody]

/gcbrun

[apeabody]

Thanks @arthurlapertosa! - Can you resolve the appropriate open comments?

[arthurlapertosa]

@erlanderlo could you please take a look at the open comments?

[erlanderlo]

lgtm. one minor item

[arthurlapertosa]

@apeabody all open comments addressed. Please take another look!

[apeabody]

/gcbrun