Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark instances_details as sensitive #389

Merged
merged 4 commits into from
Apr 23, 2024
Merged

fix: mark instances_details as sensitive #389

merged 4 commits into from
Apr 23, 2024

Conversation

ps-occrp
Copy link
Contributor

Fix terraform warning that instances_details is not marked as sensitive output

@ps-occrp ps-occrp requested a review from a team as a code owner March 21, 2024 10:07
@ps-occrp
Copy link
Contributor Author

@g-awmalik can you please review this?

@ps-occrp
Copy link
Contributor Author

@apeabody can you please review this PR?

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Apr 22, 2024
@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ps-occrp!

@apeabody apeabody merged commit c923bfe into terraform-google-modules:master Apr 23, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ps-occrp @apeabody