feat(TPG>=5.5)!: support setting maintenance_interval in instance_template

[tpdownes]

Enable setting maintenance_interval in the scheduling block of instance templates. Must use google-beta provider but does not otherwise impact version. This might make it a breaking change from your perspective. I can edit commit and PR title appropriately.

[tpdownes]

FYI: in some further testing, I'm seeing an error upon updating the field from PERIODIC to null. It is trying to do the update in-place. This maybe a TPG problem or something we could guide with a replacement trigger.

[tpdownes]

I filed an issue in TPG: hashicorp/terraform-provider-google#16345

Can you help me understand the integration test failure? It seems unrelated.

[tpdownes]

hashicorp/terraform-provider-google#16345 resolves this problem, I believe but requires upgrade to TPG 5.x. Future work to add to this PR.

[tpdownes]

@terraform-google-modules/cft-admins I would appreciate feedback on this PR as it changes to google-beta and bumps to 5.x. I could answer why this might be a support burden.

[apeabody]

Thanks for the contribution @tpdownes!

[apeabody]

From the CI:

STDERR: Error: cannot determine self_link for subnetwork "cft-vm-test-9wb5": network_interface.0.subnetwork_project: required field is not set

  with module.preemptible_and_regular_instance_templates.module.preemptible_and_regular_instance_templates.module.preemptible.google_compute_instance_template.tpl,
  on ../../../../modules/instance_template/main.tf line 65, in resource "google_compute_instance_template" "tpl":
  65: resource "google_compute_instance_template" "tpl" {

[tpdownes]

From the CI:

STDERR: Error: cannot determine self_link for subnetwork "cft-vm-test-9wb5": network_interface.0.subnetwork_project: required field is not set

  with module.preemptible_and_regular_instance_templates.module.preemptible_and_regular_instance_templates.module.preemptible.google_compute_instance_template.tpl,
  on ../../../../modules/instance_template/main.tf line 65, in resource "google_compute_instance_template" "tpl":
  65: resource "google_compute_instance_template" "tpl" {

It's unclear to me if CFT believes the correct solution here is to set the project ID at provider level or to explicitly supply subnetwork_project. Not exactly clear why this is showing up as part of this PR as it's not a documented breaking change for TPG 5.0.

https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_5_upgrade

[g-awmalik]

@apeabody - can you LGTM this?

[apeabody]

Thanks for the contribution @tpdownes!