Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable fuller networking features in instance_template module #330

Merged

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Aug 29, 2023

  • add all fields of network_interface blocks to the input variable additional_networks
  • version bump of provider is due to GA availability of network_performance_config block

There is no example for additional_networks. It is moderately more challenging than additional_disks as a good example would require networks to exist and null is a slightly more attractive value for some of these fields. What are your thoughts?

@tpdownes tpdownes requested a review from a team as a code owner August 29, 2023 19:26
@tpdownes tpdownes changed the title Enable fuller networking features in instance_template module feat: enable fuller networking features in instance_template module Aug 29, 2023
@tpdownes tpdownes force-pushed the enable_full_nic_spec branch from 7a59950 to 59d3ddb Compare August 29, 2023 19:41
@tpdownes tpdownes force-pushed the enable_full_nic_spec branch from 59d3ddb to 6145602 Compare August 29, 2023 19:45
@bharathkkb bharathkkb changed the title feat: enable fuller networking features in instance_template module feat!: enable fuller networking features in instance_template module Aug 30, 2023
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tpdownes

I think showing an example wired with networks could be useful (we do that in a few places like GKE) but that can be a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants