Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add var.resource_policies to instance_template #317

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Conversation

ryboe
Copy link
Contributor

@ryboe ryboe commented Jun 14, 2023

Resolve #315

@ryboe ryboe requested a review from a team as a code owner June 14, 2023 01:34
@google-cla
Copy link

google-cla bot commented Jun 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@nikhilmakhijani nikhilmakhijani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add resource_policies variable to README.md

@ryboe
Copy link
Contributor Author

ryboe commented Jun 25, 2023

I updated the variable description and the README. 👍

@bharathkkb
Copy link
Member

/gcbrun

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ryboe

modules/instance_template/main.tf Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feat: add var.resource_policies to instance_template feat!: add var.resource_policies to instance_template Jul 19, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

@bharathkkb - are you good with the changes?

@bharathkkb bharathkkb changed the title feat!: add var.resource_policies to instance_template feat: add var.resource_policies to instance_template Sep 29, 2023
@bharathkkb bharathkkb merged commit d959936 into terraform-google-modules:master Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please expose resource_policies as a variable for the instance_template
4 participants