Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add support of "ipv6_access_config" param for compute instance and instance template #284

Merged

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Nov 23, 2022

In google provider v3.88 there was a new param added: ipv6_access_config:
https://github.com/hashicorp/terraform-provider-google/blob/v3.90.1/CHANGELOG.md#3880-october-11-2021

It allows to configure IPv6 access configs. Docs:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_template#ipv6_access_config

This PR adds makes it possible to configure ipv6_access_config for resources:

  • google_compute_instance_from_template
  • google_compute_instance_template

@comment-bot-dev
Copy link

comment-bot-dev commented Nov 23, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@legal90 legal90 force-pushed the ipv6-access-config-support branch from 3c128c3 to a993f1e Compare November 23, 2022 14:42
@legal90 legal90 force-pushed the ipv6-access-config-support branch from a993f1e to 5164432 Compare November 29, 2022 09:34
@legal90 legal90 requested a review from a team as a code owner November 29, 2022 09:34
@apeabody apeabody self-assigned this Nov 30, 2022
@apeabody apeabody changed the title Add support of "ipv6_access_config" param for compute instance and instance template feat!: Add support of "ipv6_access_config" param for compute instance and instance template Nov 30, 2022
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @legal90!

@apeabody apeabody merged commit fc40db1 into terraform-google-modules:master Dec 1, 2022
@thinkjk thinkjk mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants