Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support health check logging #283

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

ericyz
Copy link
Contributor

@ericyz ericyz commented Nov 22, 2022

Add a flag to enable or disable health check logging.

@comment-bot-dev
Copy link

comment-bot-dev commented Nov 22, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@ericyz
Copy link
Contributor Author

ericyz commented Nov 23, 2022

@bharathkkb - please review at your convenience

@ericyz
Copy link
Contributor Author

ericyz commented Nov 23, 2022

@bharathkkb - I might need your help to review and provide feedback when you or other reviewers have a minute. Thank you.

@apeabody apeabody changed the title feat: support health check logging feat!: support health check logging Nov 28, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ericyz

@bharathkkb bharathkkb requested a review from a team as a code owner November 29, 2022 02:02
@bharathkkb bharathkkb merged commit 2b31071 into terraform-google-modules:master Nov 29, 2022
@ericyz ericyz deleted the feat/hc-logging branch November 29, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants