Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example does not work #220

Closed
thiagonache opened this issue Jan 4, 2022 · 0 comments · Fixed by #234
Closed

Example does not work #220

thiagonache opened this issue Jan 4, 2022 · 0 comments · Fixed by #234
Labels
bug Something isn't working P2 high priority issues triaged Scoped and ready for work

Comments

@thiagonache
Copy link
Contributor

TL;DR

The examples https://github.com/terraform-google-modules/terraform-google-vm/blob/master/examples/compute_instance/disk_snapshot/main.tf#L34 and https://github.com/terraform-google-modules/terraform-google-vm/blob/master/examples/mig/healthcheck/main.tf#L57 passes service_account = null and it breaks the module instance_template.

Expected behavior

Example to work

Observed behavior

Code does not work

Terraform Configuration

as in the example

Terraform Version

any

Additional information

No response
@thiagonache thiagonache added the bug Something isn't working label Jan 4, 2022
@thiagonache thiagonache mentioned this issue Jan 4, 2022
Merged
@bharathkkb bharathkkb added P2 high priority issues triaged Scoped and ready for work labels Jan 5, 2022
@thiagonache thiagonache mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add service_account variable on examples missing it
2 participants
@thiagonache @bharathkkb