Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ACM submodule with native resource #945

Closed
bharathkkb opened this issue Jul 1, 2021 · 0 comments · Fixed by #947
Closed

Replace ACM submodule with native resource #945

bharathkkb opened this issue Jul 1, 2021 · 0 comments · Fixed by #947
Assignees
@morgante
Labels
P2 high priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work

Comments

@bharathkkb
Copy link
Member

bharathkkb commented Jul 1, 2021 •
edited
Loading

We should replace current ACM module implementation with google_gke_hub_feature_membership
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/gke_hub_feature_membership
@bharathkkb bharathkkb mentioned this issue Jul 1, 2021
Open
@bharathkkb bharathkkb added P2 high priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work labels Jul 1, 2021
@morgante morgante self-assigned this Jul 1, 2021
@morgante morgante mentioned this issue Jul 8, 2021
Merged
@gaurav517 gaurav517 mentioned this issue Jul 21, 2021
Closed
@bharathkkb bharathkkb mentioned this issue Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgante morgante

Labels
P2 high priority issues refactor Updates for readability, code cleanliness, DRYness, etc. Only needs Terraform exp. triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
2 participants
@morgante @bharathkkb