Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Node pools can enable fast_socket #2200

Merged
merged 1 commit into from
Dec 7, 2024
Merged

feat: Node pools can enable fast_socket #2200

merged 1 commit into from
Dec 7, 2024

Conversation

fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Dec 4, 2024

fixes #2199

@fraenkel fraenkel requested review from ericyz, gtsorbo and a team as code owners December 4, 2024 15:44
@google-cla Google CLA
Copy link

google-cla bot commented Dec 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@apeabody
Copy link
Collaborator

apeabody commented Dec 5, 2024

/gcbrun

apeabody
apeabody requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fraenkel!

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Collaborator

apeabody commented Dec 6, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Dec 6, 2024

Thanks @fraenkel - The Terraform looks good to me, please also add the new field to the node pool documentation here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/README.md?plain=1#L186

@fraenkel
Copy link
Contributor Author

fraenkel commented Dec 6, 2024

The READMEs have been updated.

@fraenkel fraenkel requested a review from apeabody December 6, 2024 22:56
@apeabody
Copy link
Collaborator

apeabody commented Dec 6, 2024

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Dec 7, 2024

validated fast_socket is present in v6.10

@apeabody apeabody merged commit f23d52f into terraform-google-modules:master Dec 7, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node pools can enable fast sockets
2 participants
@fraenkel @apeabody