-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(update-variant)!: allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in place #2195
feat(update-variant)!: allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in place #2195
Conversation
…place Signed-off-by: drfaust92 <[email protected]>
@apeabody Dont know if tests rely on this but i would super appreciate if we can push this into v35 as well. ill make relevant changes as needed if CI fails 🙏 |
/gcbrun |
/gcbrun |
Verified this is in v6.8.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contriobution @DrFaust92!
Can you please add something to docs/upgrading_to_v35.0.md
similar to:
### Update variant random ID keepers updated |
…place Signed-off-by: drfaust92 <[email protected]>
…place Signed-off-by: drfaust92 <[email protected]>
Thanks apeabody! added the section in the upgrade guide |
/gcbrun |
/gcbrun |
this a breaking change as this will cause a recreate of the node pools once more but subsequent updates will be in place
This is a huge QOL change to allow rolling out machine type changes without node pool recreate and allowing apps to migrate gracefully
upstream ref: https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/container/node_config.go#L1937