Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(private-cluster)!: use private endpoint #2189

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Nov 20, 2024

We should use the private_endpoint when enable_private_endpoint is true, even if deploy_using_private_endpoint is not.

Needed for TPG v6.11+

@apeabody apeabody marked this pull request as ready for review November 21, 2024 16:12
@apeabody apeabody requested review from ericyz, gtsorbo and a team as code owners November 21, 2024 16:12
@apeabody apeabody changed the title fix(private-cluster): use private endpoint fix(private-cluster)!: use private endpoint Nov 21, 2024
@apeabody apeabody force-pushed the ap/private_endpoint branch 3 times, most recently from 3f90c83 to e4ddf7f Compare November 22, 2024 22:07
@apeabody apeabody force-pushed the ap/private_endpoint branch from e4ddf7f to 387002b Compare November 22, 2024 22:08
@apeabody apeabody enabled auto-merge (squash) November 22, 2024 23:19
@apeabody apeabody merged commit 4b155cd into master Nov 23, 2024
8 checks passed
@apeabody apeabody deleted the ap/private_endpoint branch November 23, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants